Bug Tracker

Ticket #14731 (closed bug: fixed)

#14731 closed bug (fixed)

Checking .css('marginRight') after width() can give incorrect results

Reported by: m_gol Owned by: m_gol
Priority: low Milestone: 1.11.1
Component: css Version: 1.11.0
Keywords: Cc:
Blocked by: Blocking:


As @timmywil discovered here (with help from @jdalton): https://github.com/jquery/jquery/commit/bbbdd947256a3fcd788fb9d4f306046082a1ef1f#commitcomment-5173866 we're caching the reliableMarginRight support test result in a variable that is also pre-set when computing the boxSizingReliable support test. This leads to an incorrect test result and can lead to erroneous output.

The reliableMarginRight caching can just be removed since the function is executed only once, in the addGetHookIf function. This will solve the bug.

2.x doesn't have this problem.

Change History

comment:1 Changed 22 months ago by m_gol

comment:1 Changed 22 months ago by m_gol

  • Component changed from unfiled to css
  • Milestone changed from None to 1.11.1
  • Owner set to m_gol
  • Priority changed from undecided to low
  • Status changed from new to assigned

comment:2 Changed 22 months ago by m_gol

comment:2 Changed 22 months ago by m_gol

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.