Bug Tracker

Changes between Initial Version and Version 1 of Ticket #14659, comment 2


Ignore:
Timestamp:
Dec 31, 2013, 5:25:59 PM (10 years ago)
Author:
dmethvin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14659, comment 2

    initial v1  
    1 I think the consistency issue is a better argument, since we don't use `Object.keys` anywhere else. However, the good thing about it would be that potentially we could survive augmentation of `Object` if we used this everywhere, since it only enumerates own properties? The for/in makes the code a bit shorter and simpler, I haven't looked to see the impact on gzip though.
     1I think the consistency issue is a better argument, since we don't use `Object.keys` anywhere else. However, the good thing about it would be that potentially we could survive augmentation of `Object.prototype` if we used this everywhere, since it only enumerates own properties? The for/in makes the code a bit shorter and simpler, I haven't looked to see the impact on gzip though.