Opened 9 years ago
Closed 8 years ago
#14633 closed bug (migrated)
removeAttr("selected") should not set property to false
Reported by: | Owned by: | timmywil | |
---|---|---|---|
Priority: | low | Milestone: | 1.12/2.2 |
Component: | attributes | Version: | 2.0.3 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
In Firefox the selected value is 1. In Chrome the selected value is 2.
removeAttr has special handing for boolean attributes to set the corresponding DOM property to false: https://github.com/jquery/jquery/blob/master/src/attributes/attr.js#L86
Removing an attribute and setting the DOM property to false are very different. In this case, as specified (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-option-selected), setting the property to false means setting the dirtiness to true. This changes how the option should react to "selected" attribute changes. In the test case, it means that adding the "selected" attribute at the end should not select the option.
Firefox respects the specified behaviour and does not select the second option.
Change History (5)
comment:1 Changed 9 years ago by
Milestone: | None → 1.12/2.2 |
---|---|
Status: | new → open |
comment:2 Changed 9 years ago by
Component: | unfiled → attributes |
---|
comment:3 Changed 9 years ago by
Owner: | set to timmywil |
---|---|
Status: | open → assigned |
comment:4 Changed 8 years ago by
Priority: | undecided → low |
---|
comment:5 Changed 8 years ago by
Resolution: | → migrated |
---|---|
Status: | assigned → closed |
Migrated to https://github.com/jquery/jquery/issues/1759
I agree this is the right thing to do, but perhaps not the compatible thing. Let's kick this can down the road for now.