Bug Tracker

Opened 6 years ago

Closed 5 years ago

#14633 closed bug (migrated)

removeAttr("selected") should not set property to false

Reported by: wchen@… Owned by: timmywil
Priority: low Milestone: 1.12/2.2
Component: attributes Version: 2.0.3
Keywords: Cc:
Blocked by: Blocking:

Description

http://jsfiddle.net/b85D4/5/

In Firefox the selected value is 1. In Chrome the selected value is 2.

removeAttr has special handing for boolean attributes to set the corresponding DOM property to false: https://github.com/jquery/jquery/blob/master/src/attributes/attr.js#L86

Removing an attribute and setting the DOM property to false are very different. In this case, as specified (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-option-selected), setting the property to false means setting the dirtiness to true. This changes how the option should react to "selected" attribute changes. In the test case, it means that adding the "selected" attribute at the end should not select the option.

Firefox respects the specified behaviour and does not select the second option.

Change History (5)

comment:1 Changed 6 years ago by dmethvin

Milestone: None1.12/2.2
Status: newopen

I agree this is the right thing to do, but perhaps not the compatible thing. Let's kick this can down the road for now.

comment:2 Changed 6 years ago by timmywil

Component: unfiledattributes

comment:3 Changed 5 years ago by timmywil

Owner: set to timmywil
Status: openassigned

comment:4 Changed 5 years ago by m_gol

Priority: undecidedlow

comment:5 Changed 5 years ago by m_gol

Resolution: migrated
Status: assignedclosed
Note: See TracTickets for help on using tickets.