Bug Tracker

Opened 6 years ago

Closed 6 years ago

#14543 closed feature (invalid)

Move more types constants to separate variables like strundefined

Reported by: FarSeeing Owned by: FarSeeing
Priority: undecided Milestone: None
Component: unfiled Version: 2.1.0-beta1
Keywords: Cc:
Blocked by: Blocking:

Description

As typeof undefined is stored in strundefined why not also store other types?

  1. g. "object" constant is used 17 times in 10 different files as per commit 203569562414304aabec22fd20b0cb17ad34c7ad

Change History (2)

comment:1 in reply to:  description Changed 6 years ago by gibson042

Owner: set to FarSeeing
Status: newpending

strundefined was introduced to work around a minification issue with UglifyJS that replaced typeof el.domMethod !== "undefined" with e.domMethod!==void 0, which breaks in IE when el is an XML node (see #13315). The issue has since been fixed, so it's worth looking at the effects on output size of comparing typeof output to variables or constants for all cases. Would you like to tackle this, FarSeeing?

comment:2 Changed 6 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.