Skip to main content

Bug Tracker

Side navigation

#14343 closed feature (migrated)

Opened September 07, 2013 02:55PM UTC

Closed October 21, 2014 12:21AM UTC

Remove size & andSelf methods deprecated in jQuery 1.8

Reported by: m_gol Owned by: m_gol
Priority: low Milestone: 1.next/2.next
Component: core Version: 1.10.2
Keywords: Cc:
Blocked by: Blocking:
Description

It's high time to remove jQuery.fn.size and jQuery.fn.andSelf methods. They've been deprecated since 1.8 so removing them in 2.1/1.11 seems fine.

Attachments (0)
Change History (15)

Changed September 07, 2013 05:05PM UTC by m_gol comment:1

owner: → m_gol
status: newassigned

Changed September 07, 2013 05:08PM UTC by m_gol comment:2

milestone: None1.11/2.1
priority: undecidedlow

Changed September 07, 2013 05:09PM UTC by m_gol comment:3

Changed September 07, 2013 07:02PM UTC by dmethvin comment:4

This seems like a lot of risk for very little benefit. Those two have been deprecated for a while I suspect there is still quite a bit of usage out there. It's pretty hard to tell.

https://github.com/search?p=2&q=andSelf+jquery&type=Code

Changed September 08, 2013 05:14PM UTC by m_gol comment:5

What about jQuery.fn.size? It's hard to check it due to being a more common name. On the other hand, size code is much larger than andSelf one considering the latter is just an alias to another function.

Changed September 08, 2013 08:36PM UTC by dmethvin comment:6

Do we have any other api changes in this next release? I would rather batch these up since they can be disruptive and discourage upgrading.

Changed September 08, 2013 08:59PM UTC by m_gol comment:7

_comment0: Well, it's not officially public API but the whole `jQuery.support` behaves now differently, e.g. some former properties are now functions. \ \ That's actually why I thought about 1.11/2.1 timeframe because we're changing so much but maybe you're right most of these changes are internal and have little effect on our public API.1378674249510895

Well, it's not officially public API but the whole jQuery.support behaves now differently, e.g. some former properties are now functions.

That's actually why I thought about 1.11/2.1 timeframe because we're changing so much with the switch to AMD etc. but maybe you're right most of these changes are internal and have little effect on our public API.

Changed September 08, 2013 09:24PM UTC by timmywil comment:8

Officially, we haven't made any changes to our public API (support is documented as changeable). Every API change is annoying to our users, even if it makes sense.

I'd say we should just keep them in. Deprecated can refer to our recommendations and doesn't have to mean removable. They are easily removable with custom builds, if so desired and they take up little space anyway.

Changed September 10, 2013 08:06PM UTC by dmethvin comment:9

component: unfiledcore
milestone: 1.11/2.12.next

Let's hold off on this one until the following major release at least.

Changed September 16, 2013 08:57PM UTC by m_gol comment:10

milestone: 2.next1.next/2.next

Changed March 01, 2014 10:14PM UTC by dmethvin comment:11

Neither of these seem all that important to me. The first step would be to get them into Migrate ASAP.

Changed March 16, 2014 05:27PM UTC by dmethvin comment:12

Changed April 30, 2014 09:48PM UTC by m_gol comment:13

Do we want to do it for 1.12/2.2?

Changed April 30, 2014 09:49PM UTC by m_gol comment:14

Actually, why don't we log deprecation errors for them in Core as well? .andSelf is just an alias so we'd need a wrapper but in .size() it'd be quite easy.

Changed October 21, 2014 12:21AM UTC by m_gol comment:15

resolution: → migrated
status: assignedclosed