Bug Tracker

Opened 6 years ago

Closed 5 years ago

#14343 closed feature (migrated)

Remove size & andSelf methods deprecated in jQuery 1.8

Reported by: m_gol Owned by: m_gol
Priority: low Milestone: 1.next/2.next
Component: core Version: 1.10.2
Keywords: Cc:
Blocked by: Blocking:

Description

It's high time to remove jQuery.fn.size and jQuery.fn.andSelf methods. They've been deprecated since 1.8 so removing them in 2.1/1.11 seems fine.

Change History (15)

comment:1 Changed 6 years ago by m_gol

Owner: set to m_gol
Status: newassigned

comment:2 Changed 6 years ago by m_gol

Milestone: None1.11/2.1
Priority: undecidedlow

comment:4 Changed 6 years ago by dmethvin

This seems like a lot of risk for very little benefit. Those two have been deprecated for a while I suspect there is still quite a bit of usage out there. It's pretty hard to tell.

https://github.com/search?p=2&q=andSelf+jquery&type=Code

comment:5 Changed 6 years ago by m_gol

What about jQuery.fn.size? It's hard to check it due to being a more common name. On the other hand, size code is much larger than andSelf one considering the latter is just an alias to another function.

comment:6 Changed 6 years ago by dmethvin

Do we have any other api changes in this next release? I would rather batch these up since they can be disruptive and discourage upgrading.

comment:7 Changed 6 years ago by m_gol

Well, it's not officially public API but the whole jQuery.support behaves now differently, e.g. some former properties are now functions.

That's actually why I thought about 1.11/2.1 timeframe because we're changing so much with the switch to AMD etc. but maybe you're right most of these changes are internal and have little effect on our public API.

Last edited 6 years ago by m_gol (previous) (diff)

comment:8 Changed 6 years ago by timmywil

Officially, we haven't made any changes to our public API (support is documented as changeable). Every API change is annoying to our users, even if it makes sense.

I'd say we should just keep them in. Deprecated can refer to our recommendations and doesn't have to mean removable. They are easily removable with custom builds, if so desired and they take up little space anyway.

comment:9 Changed 6 years ago by dmethvin

Component: unfiledcore
Milestone: 1.11/2.12.next

Let's hold off on this one until the following major release at least.

comment:10 Changed 6 years ago by m_gol

Milestone: 2.next1.next/2.next

comment:11 Changed 6 years ago by dmethvin

Neither of these seem all that important to me. The first step would be to get them into Migrate ASAP.

comment:13 Changed 5 years ago by m_gol

Do we want to do it for 1.12/2.2?

comment:14 Changed 5 years ago by m_gol

Actually, why don't we log deprecation errors for them in Core as well? .andSelf is just an alias so we'd need a wrapper but in .size() it'd be quite easy.

comment:15 Changed 5 years ago by m_gol

Resolution: migrated
Status: assignedclosed
Note: See TracTickets for help on using tickets.