Bug Tracker

Opened 13 years ago

Closed 13 years ago

#1392 closed bug (invalid)

Gecko is gecko

Reported by: Jonno Owned by:
Priority: minor Milestone: 1.2.1
Component: core Version: 1.2
Keywords: Cc:
Blocked by: Blocking:

Description

http://geckoisgecko.org/

Basicaly, detecting "Mozilla" is not very smart (as many, but not all, non-Mozilla browsers include Mozilla in their user agents). The only safe way I know about to reliably detect a Mozilla based browser is to look for Gecko/YYYYMMDD in the user agent (other browser may include "like Gecko", but none other include the gecko build date).

More browsers than Opera might masquerade as MSIE. The only way to reliably detect for MSIE is to use Conditional Compilation of JavaScript in IE.

The attached patch fixes these issues as well as adds support for khtml (very similar to WebKit).

Attachments (1)

geckoisgecko.patch (3.6 KB) - added by Jonno 13 years ago.

Download all attachments as: .zip

Change History (2)

Changed 13 years ago by Jonno

Attachment: geckoisgecko.patch added

comment:1 Changed 13 years ago by john

Milestone: 1.1.41.2.1
Resolution: invalid
Status: newclosed
Version: 1.1.31.2

Our current implementation works for all browsers that we support - if a user is spoofing their useragent, then they're obviously asking for that browser's specific implementation of functionality. We should not try to circumvent that.

Note: See TracTickets for help on using tickets.