Bug Tracker

Opened 7 years ago

Closed 7 years ago

#13523 closed bug (invalid)

Identity comparator in isWindow should be strict equality operator

Reported by: carson@… Owned by: carson@…
Priority: undecided Milestone: None
Component: unfiled Version: 1.9.1
Keywords: Cc:
Blocked by: Blocking:

Description

Identity comparator in isWindow should be strict equality operator

BUG: In the $.isWindow check, the righthand expression in the return conditional should probably use obj === obj.window (currently uses ==).

REASON: The seq is more accurate, faster, and safer in this case.

Change History (3)

comment:1 Changed 7 years ago by Rick Waldron

Owner: set to carson@…
Status: newpending

comment:2 Changed 7 years ago by dmethvin

Seems like it would on oldIE, but Carson sounded pretty certain so let's wait for a test case.

comment:3 Changed 7 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.