Opened 11 years ago
Closed 11 years ago
#13523 closed bug (invalid)
Identity comparator in isWindow should be strict equality operator
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | undecided | Milestone: | None |
| Component: | unfiled | Version: | 1.9.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Identity comparator in isWindow should be strict equality operator
BUG: In the $.isWindow check, the righthand expression in the return conditional should probably use obj === obj.window (currently uses ==).
REASON: The seq is more accurate, faster, and safer in this case.
Change History (3)
comment:1 Changed 11 years ago by
| Owner: | set to carson@… |
|---|---|
| Status: | new → pending |
comment:2 Changed 11 years ago by
Seems like it would on oldIE, but Carson sounded pretty certain so let's wait for a test case.
comment:3 Changed 11 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
Does that change break this: https://github.com/jquery/jquery/commit/0fcfac7568823a4eec4e5dd7b9bf527a8ec04f5c ?