Stack overflow if element which binded pure namespace event unbind a pure namespace event

[c4605]

$(document).on(".test",function(){console.log("test success")}).off(".test") // Stack Overflow

[c4605]

​http://jsfiddle.net/vTqH3/

[c4605]

bootstrap bind event by this way: ​https://github.com/twitter/bootstrap/blob/master/js/bootstrap-dropdown.js#L161

[Rick Waldron]

Confirmed.

[Rick Waldron]

• 1.9.x ​https://github.com/jquery/jquery/pull/1171
• 2.x ​https://github.com/jquery/jquery/pull/1172

[Rick Waldron]

Sorry, but after further discussion and review, that signature isn't actually supported by jQuery.

[dmethvin]

Reopening so we can turn this into a no-op rather than an infinite loop, but the root problem is this line:

.on('.dropdown-menu', function (e) { e.stopPropagation() })

You must specify a type name. The docs say the type name may be qualified by a namespace, but not that the type name is optional. It's only optional when removing events.

[dmethvin]

Whoops, meant to reopen.

There is a pull request to fix the Bootstrap problem; see the reference to the bug report there as well.

​https://github.com/twitter/bootstrap/pull/6970

[c4605]

maybe we need throw an error when bind this event?

i think many people (for example me) will do like this

[anonymous]

thnk q very much Replying to c4605:

$(document).on(".test",function(){console.log("test success")}).off(".test") // Stack Overflow

[Dave Methvin]

Fix #13471. $().on(".xyz"...) should avoid later crash.

If the event type is an empty string we end up hanging in .off() which makes for mighty hard debugging. Instead treat it as a no-op. Docs seem clear this is not allowed.

Changeset: 2bbc3d5860b81e128cd92f865673e10046caac7d

[Dave Methvin]

Fix #13471. $().on(".xyz"...) should avoid later crash.

If the event type is an empty string we end up hanging in .off() which makes for mighty hard debugging. Instead treat it as a no-op. Docs seem clear this is not allowed.

Changeset: f5163914fa1a751aa5bf10ce48c4b5307d65ed90