Bug Tracker

Opened 10 years ago

Closed 10 years ago

#13154 closed bug (notabug)

Remove $.sub leftovers

Reported by: anonymous Owned by: anonymous
Priority: undecided Milestone: None
Component: unfiled Version: git
Keywords: Cc:
Blocked by: Blocking:

Description

There are places in the source code where this.constructor is used. Now that $.sub is removed, these can safely be set back to jQuery. The call in .end also doesn't need null.

Change History (3)

comment:1 Changed 10 years ago by Rick Waldron

Owner: set to anonymous
Status: newpending

I suspect this would break the jQuery migration plugin... https://github.com/jquery/jquery-migrate

comment:2 Changed 10 years ago by dmethvin

Right, we need to be able to add it back via jquery-migrate so this change shouldn't be made.

BTW, right now the PhantomJS unit tests in the plugin are broken when tested with 2.0 because of the .apply(this, NodeList) changes which PhantomJS doesn't like. It seems to pass in real browsers though.

comment:3 Changed 10 years ago by dmethvin

Resolution: notabug
Status: pendingclosed
Note: See TracTickets for help on using tickets.