Bug Tracker

Changes between Initial Version and Version 1 of Ticket #12978, comment 2


Ignore:
Timestamp:
Nov 28, 2012, 12:34:54 PM (9 years ago)
Author:
dmethvin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12978, comment 2

    initial v1  
    1 I agree with gibson042 here. If the first failed promise failed the collection, for example, you wouldn't know when the unfailed animations completed.
     1I agree with gibson042 here. If the first *xxxx* stop()ped animation failed the collection, for example, you wouldn't know when the unfailed animations completed.
    22
    33We already provide the tools to solve this. The code stopping the animation isn't some remote external force, so it can easily coordinate a signal with other code in the app. For example, to get a failed promise you could join both the animate promise and a second promise that you `.reject()` in the function where `.stop()` is called. Wrap it all up in your own method to keep it DRY.