overflow:hidden is not removed when .stop() is called

[Ult Combo]

I'm aware that when animating the dimensions of a div, overflow:hidden is added to the element style in order to don't show scrollbars.

The overflow property is removed from the element style when the animation is complete. However, that doesn't happen when I call the .stop method.

​Normal behavior - Without .stop(), scrollbars are hidden while animating and restored to default after animation.

​Test case - trigger the div's mouseenter then mouseleave while it is animating to invoke the .stop() method, the overflow:hidden stays in the element style and scrollbars are gone for good.

Temporary workaround: Set overflow:auto !important; in the CSS when the div is supposed to have scrollbars.

Proposed patch: remove the added overflow:hidden from the element style when .stop() is invoked.

I'd suggest not adding the overflow property if the element already has one, but in that case it could break back-compat. Therefore simply restoring the overflow when .stop() is called as if the animation had completed should suffice.

[Timmy Willison]

This sounds really familiar, but I can't find a related ticket.

[Timmy Willison]

#12951 is a duplicate of this ticket.

[mikesherov]

this one is as simple as changing anim.done to anim.always for the overflow sets. Will have a pull request shortly.

[Dave Methvin]

Fix #12846. Restore overflow when animation is stopped.

Changeset: a6c358d04693c5746e1557a2660dfccb169ad831

[Dave Methvin]

Fix #12846. Restore overflow when animation is stopped.

(Cherry picked from a6c358d)

Changeset: 3f9f2b1dbcefdafc5ef11f7deb222a3b6d8941d8