Skip to main content

Bug Tracker

Side navigation

#12741 closed bug (fixed)

Opened October 16, 2012 12:08PM UTC

Closed January 06, 2013 03:14PM UTC

inconsistent line endings in official jquery-1.8.2.js download

Reported by: oberhamsi Owned by:
Priority: high Milestone: 1.9
Component: build Version: 1.8.2
Keywords: needsreview Cc:
Blocked by: Blocking:

subversion was angy when I tried to add jquery. And to my surprise it was right: jquery-1.8.2.js download has inconsitent line ending.

it seems the sizzle lines are the offenders. before and after sizzle everything has clean "\\n". but from line 3668 on i see "\\r\\n".

I cloned sizzle from github and it doesn't have this problem. i did not try to build jquery to figure out at which steps the '/r' are added.

I expected all lines to end in "\\n".

simon@duchov:/tmp$ wget
simon@duchov:/tmp$ grep -n $'\\r' jquery-1.8.2.js | head
3669: * Sizzle CSS Selector Engine
3670: * Copyright 2012 jQuery Foundation and other contributors
3671: * Released under the MIT license
3672: *
3673: */
3674:(function( window, undefined ) {
3676:var cachedruns,
3677:	assertGetIdNotName,

Attachments (0)
Change History (5)

Changed October 16, 2012 01:35PM UTC by timmywil comment:1

component: unfiledbuild
keywords: → needsreview
milestone: None1.8.3
priority: undecidedhigh
status: newopen

This could be an issue with the build. Needs investigation.

Changed October 16, 2012 02:24PM UTC by dmethvin comment:2

Most likely because it's using the native line endings for jQuery where I build and release in Windows, but the git line endings for the submodules which were built in Unix.

Changed November 11, 2012 08:31PM UTC by dmethvin comment:3


Changed November 21, 2012 05:09PM UTC by dmethvin comment:4

#12939 is a duplicate of this ticket.

Changed January 06, 2013 03:14PM UTC by dmethvin comment:5

resolution: → fixed
status: openclosed