Opened 10 years ago
Closed 10 years ago
#12741 closed bug (fixed)
inconsistent line endings in official jquery-1.8.2.js download
Reported by: | oberhamsi | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | 1.9 |
Component: | build | Version: | 1.8.2 |
Keywords: | needsreview | Cc: | |
Blocked by: | Blocking: |
Description
subversion was angy when I tried to add jquery. And to my surprise it was right: jquery-1.8.2.js download has inconsitent line ending.
it seems the sizzle lines are the offenders. before and after sizzle everything has clean "\n". but from line 3668 on i see "\r\n".
I cloned sizzle from github and it doesn't have this problem. i did not try to build jquery to figure out at which steps the '/r' are added.
I expected all lines to end in "\n".
[email protected]:/tmp$ wget http://code.jquery.com/jquery-1.8.2.js [email protected]:/tmp$ grep -n $'\r' jquery-1.8.2.js | head 3668:/*! 3669: * Sizzle CSS Selector Engine 3670: * Copyright 2012 jQuery Foundation and other contributors 3671: * Released under the MIT license 3672: * http://sizzlejs.com/ 3673: */ 3674:(function( window, undefined ) { 3675: 3676:var cachedruns, 3677: assertGetIdNotName,
Change History (5)
comment:1 Changed 10 years ago by
Component: | unfiled → build |
---|---|
Keywords: | needsreview added |
Milestone: | None → 1.8.3 |
Priority: | undecided → high |
Status: | new → open |
comment:2 Changed 10 years ago by
Most likely because it's using the native line endings for jQuery where I build and release in Windows, but the git line endings for the submodules which were built in Unix.
comment:3 Changed 10 years ago by
Milestone: | 1.8.3 → 1.9 |
---|
comment:5 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | open → closed |
Fix #12471. Use consistent line endings in jquery.js
https://github.com/jquery/jquery/commit/b760d798d35d4c945c9c5240bb8cb4719330ad1f
This could be an issue with the build. Needs investigation.