Skip to main content

Bug Tracker

Side navigation

#12111 closed bug (duplicate)

Opened July 20, 2012 08:46AM UTC

Closed September 08, 2012 08:00PM UTC

is(':visible') and filter(':visible') give different results for window and document

Reported by: Owned by:
Priority: undecided Milestone: None
Component: traversing Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

When checking for visibility $(window).is(':visible') and $(document).is(':visible') return true, but $([window, document]).filter(':visible') returns empty array.

In other words, is(':visible') thinks that window and document are visible, but filter(':visible') thinks not.

Test page at (results for is and filter should match).

Tested in jQuery 1.6.4 and 1.7.2.

Attachments (0)
Change History (6)

Changed July 20, 2012 02:53PM UTC by dmethvin comment:1

owner: →
status: newpending

I think this is just a case of both being inappropriate inputs, since neither of those are DOM elements and so a check for == "none" doesn't make sense.

Are you specifically asking for them both to return true under all circumstances regardless of actual visibility of the document/window, or would a consistent false be okay as well? Can you point to some code that depends on this?

Changed July 20, 2012 05:26PM UTC by anonymous comment:2

At least results should be consistent, but both ways have pros and cons. In common sense window and document are visible to user, so visibility checks should return true. On the other side as you said they technically are not DOM elements, so leaving them after filter() may break next code in call chain (e.g. $(window).filter(':visible').offset().left will give error).

Visual Event ( currently depends on filter, and processes all DOM elements plus window and document and possibly document.body or document.documentElement. I've tried to replace in its code $(node).filter(':visible').length===0 with shorter !$(node).is(':visible') and found this inconsistency.

IMHO consistent false will be OK unless someone has code which already depends on this specific feature.

Changed July 24, 2012 09:41PM UTC by dmethvin comment:3

status: pendingopen

Given the potential for breaking code that depends on one or the other, I don't think we can tackle this for 1.8. I'll mark it valid for now but it may end up being a wontfix.

Another issue I can think of here is that :visible and :hidden are generally thought of as opposites; if we say a window or document are never visible they will always be hidden.

Changed August 15, 2012 02:15PM UTC by anonymous comment:4

This bug was posted couple of months ago and closed as invalid

I even found it exactly the same way (while modifying VisualEvent source) :)

Changed September 05, 2012 03:24AM UTC by mikesherov comment:5

component: unfiledtraversing

Changed September 08, 2012 08:00PM UTC by mikesherov comment:6

resolution: → duplicate
status: openclosed

Duplicate of #11563.