Skip to main content

Bug Tracker

Side navigation

#11938 closed feature (fixed)

Opened June 20, 2012 11:15AM UTC

Closed December 11, 2012 06:59PM UTC

jQuery.css should accept an array to get multiple properties

Reported by: damien Owned by: mikesherov
Priority: high Milestone: 1.9
Component: css Version: git
Keywords: 1.9-discuss Cc:
Blocked by: Blocking:

If css receives no arguments it should return all computed parameters of the given object.

Attachments (0)
Change History (15)

Changed June 20, 2012 11:56AM UTC by dmethvin comment:1

owner: → damien
status: newpending

What is the use case for this? Can you provide some sample code where it would be useful?

Changed June 20, 2012 12:02PM UTC by damien comment:2

status: pendingnew

e.g. if you want to clone an object and append it to a different scope in the DOM then some styles applied through CSS classes will not work anymore.

In case it would be possible to receive all computed styles as an Object sth like that would be possible.


I know this could be achieved through getComputedStyle() though a jQuery integration would make sense since it already handles the IE fallbacks for that.

Changed June 20, 2012 03:12PM UTC by mikesherov comment:3

I like this too. There are a few places in the dimensions and offset code where we make multiple jQuery.css calls that go to getComputedStyle multiple times where we could be going once.

I imagine that we can also accept an array as the first param with semantics of:

var a = jQuery(elem).css(['float', 'paddingLeft', 'marginLeft');
var b = {
    'float': jQuery(elem).css('float'),
    'paddingLeft': jQuery(elem).css('paddingLeft'),
    'marginLeft': jQuery(elem).css('marginLeft')
a === b; //true

If we pass no arguments, we can just scrub every value that is returned by getComputedStyle and normalized. Meaning, prefixed property names get unprefixes, cssFloat gets made to float, etc...

At the very least, I like the version with array of properties passed in.

Changed June 20, 2012 05:16PM UTC by dmethvin comment:4

The use of an array of properties is something that has been proposed before, but might be cheap to do across all getter APIs now that gibson042 has refactored jQuery.access. For example you might want to get all four border widths at once.

As to the original proposal, I still am not sure why you'd want to do this. If the original element got its properties from a CSS cascade that included relative measurements, your copy will be nailed to absolute values and thus won't be a faithful copy anyway. Seems like it would be better to just copy the classes and use classes alone for presentational CSS values.

Changed June 21, 2012 08:56AM UTC by damien comment:5

Just to copy the classes wouldn't work in a context switch. For example I'm moving objects into a iFrame so I lose the style. Moving the class definitions to the iframe is not an option because I can't be sure if the class is not already i use...

However forget the empty option, I think the array option would be really helpful.

Changed June 21, 2012 12:37PM UTC by mikesherov comment:6

component: unfiledcss
priority: undecidedlow
status: newopen
summary: jQuery.css should return all computed parametersjQuery.css should accept an array to get multiple properties
type: enhancementfeature

Damien, I left comments on the PR. While I agree that adding array accessor to jQuery access is tempting, I think we need to consider a perf boost here to be a bigger priority. Your PR does dmethvin's suggestion, which is a good one, but completely blocks us from being able to optimize that code path for speed.

Changed June 21, 2012 01:32PM UTC by dmethvin comment:7

keywords: → 1.9-discuss

Changed July 14, 2012 02:12AM UTC by dmethvin comment:8

milestone: None1.9

Changed September 27, 2012 01:47PM UTC by gibson042 comment:9

+1 for further investigation. This has a lot of promise.

Changed October 08, 2012 08:18PM UTC by mikesherov comment:10

+1, yes, especially if we can do it in one gCS call:

Changed October 22, 2012 05:21PM UTC by gibson042 comment:11


Changed October 22, 2012 05:29PM UTC by gnarf comment:12

+1, I've always thought there should be a way to get multiple values out of CSS

Changed October 29, 2012 05:04PM UTC by mikesherov comment:13

owner: damienmikesherov
status: openassigned

Changed December 04, 2012 05:24AM UTC by gibson042 comment:14

priority: lowhigh

Changed December 11, 2012 06:59PM UTC by Mike Sherov comment:15

resolution: → fixed
status: assignedclosed

Fixes #11938: Adding array getter method to jQuery.fn.css

Changeset: ef6d8779de9d5959eafc0b9706b90a585aaf7a26