Opened 6 years ago
Closed 6 years ago
#11737 closed feature (fixed)
Remove jQuery.sub
| Reported by: | dmethvin | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | low | Milestone: | 1.9 |
| Component: | core | Version: | 1.7.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
- It is quirky, per #11662.
- It is not commonly used.
- It shouldn't be commonly used.
- It is bytes we don't want to drag around.
- It can be a plugin.
Change History (6)
comment:1 Changed 6 years ago by
| Component: | unfiled → core |
|---|---|
| Milestone: | None → 1.8 |
| Priority: | undecided → low |
| Status: | new → open |
comment:2 Changed 6 years ago by
comment:3 Changed 6 years ago by
| Owner: | set to dmethvin |
|---|---|
| Status: | open → assigned |
| Summary: | Deprecate jQuery.sub → Remove jQuery.sub |
This was actually deprecated in 1.7 so it can be removed in 1.8.
comment:4 Changed 6 years ago by
| Milestone: | 1.8 → 1.9 |
|---|
Pushed to 1.9 so we can do all the deprecations together.
comment:5 Changed 6 years ago by
| Type: | enhancement → feature |
|---|
Bulk change from enhancement to feature.
comment:6 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Moved to jquery-compat at https://github.com/jquery/jquery/commit/6b14cef7a85d22d979266a754b2a279ecd636b24
Note: See
TracTickets for help on using
tickets.
I'm torn on this one. The main utility of
jQuery.subis for plugins, which makes converting it into a plugin of its own pointless. It's not much code to insert into a plugin, but on the other hand it dives pretty deep into partially undocumented internals, and asking plugin authors to copy in that block of code means not only redundancy but also missing out on things like a fix to #11662.I was excited for the introduction of
jQuery.sub, and think I'd like to try saving it.