Skip to main content

Bug Tracker

Side navigation

#11435 closed bug (fixed)

Opened March 04, 2012 05:49PM UTC

Closed May 16, 2012 06:04PM UTC

Last modified August 10, 2012 12:08AM UTC

Obsolete test code to remove toJSON from .data's return value

Reported by: Owned by:
Priority: low Milestone: 1.8
Component: data Version: git
Keywords: Cc:
Blocked by: Blocking:

The ".data()" test in test/unit/data.js has this code (in 2 places):

	// TODO: Remove this hack which was introduced for 1.5.1
	delete dataObj.toJSON;

Commit d5f144a7 changed the way works so that the .toJSON isn't included, so I think this code is no longer necessary. I removed it and the test still passed.

Attachments (0)
Change History (4)

Changed March 05, 2012 05:15PM UTC by addyosmani comment:1

priority: undecidedlow
status: newopen

This was just mentioned in -meeting and it looks like we're going to try addressing it. Marking as valid.

Changed May 16, 2012 06:04PM UTC by Andy Monat comment:2

resolution: → fixed
status: openclosed

Fix #11435. Remove obsolete test code.

Changeset: dc337f628c0d2a4f6d691851eb95a622599e38b2

Changed May 16, 2012 06:13PM UTC by dmethvin comment:3

milestone: None1.8

Changed August 10, 2012 12:08AM UTC by dmethvin comment:4

component: unfileddata