Opened 11 years ago
Closed 11 years ago
#11224 closed bug (wontfix)
$.ajaxSetup data object does not merge when $.ajax call passes a string.
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | undecided | Milestone: | None |
Component: | unfiled | Version: | 1.7.1 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
I'm trying to use $.ajaxSetup to add a default parameter to every ajax request on my page, but it's being made more difficult by this bug combined with some bad code a contractor wrote.
If I make any ajax calls using jquery, and I define my parameters as a urlencoded string instead of a javascript object, they will ignore the defaults set by $.ajaxSetup. consider the following example code:
$(function(){
$.ajaxSetup({'data': {'secret': 'token'}}); $.get("/echo/json/", "param=stuff"); $.get("/echo/json/", {"param": "stuff"});
});
The first .get call requests /echo/json/?param=stuff whereas the second requests /echo/json/?param=stuff&secret=token.
Would be kind of nice if this would parse the query stringified version into an object, then do the merge.
Change History (3)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Status: | new → open |
---|
I am not sure whether this is a case we should handle, but if not we should document it.
comment:3 Changed 11 years ago by
Resolution: | → wontfix |
---|---|
Status: | open → closed |
We definitely shouldn't handle this. Cost is prohibitive. Don't encode your parameters OR deserialize them before giving them to $.ajax.
I added the following hack to my local copy of jQuery. (started with version 1.4.2, line 4982.)
this works in my use case, but probably breaks others.