Bug Tracker

Opened 8 years ago

Closed 7 years ago

#11164 closed feature (wontfix)

document all support tests

Reported by: mikesherov Owned by: mikesherov
Priority: low Milestone: 1.next
Component: support Version: 1.7.1
Keywords: Cc: paul.irish
Blocked by: Blocking:

Description

Yes, we all love feature detection, but what about support tests? It's a good idea to know what browser(s) caused you to write the test in the first place in case we ever decide to drop support for that browser. It'd also be good to know if there was a publicly tracked bug report for the support test.

I'm going to go through each support test and figure out what browser it is written for, and see if there are any bug tracker tickets, and then document each one with a standard set of comments. I hope that at best, this exposes some archaic removable support tests, and at worst, prepares us for the next time we want to drop a browser.

Change History (9)

comment:1 Changed 8 years ago by mikesherov

Component: unfiledsupport
Milestone: None1.8
Owner: set to mikesherov
Priority: undecidedlow
Status: newassigned

comment:2 Changed 8 years ago by Rick Waldron

I think a lot of this can be found in test/unit/support.js right?

comment:3 Changed 8 years ago by timmywil

This should not be officially documented, but with comments in support.js, as rwaldron indicates.

comment:4 Changed 8 years ago by mikesherov

"I'm going to go through each support test and figure out what browser it is written for, and see if there are any bug tracker tickets, and then document each one with a standard set of comments."

Yes, documenting it in code :-)

comment:5 Changed 8 years ago by paul.irish

Cc: paul.irish added

comment:6 Changed 8 years ago by dmethvin

If we can have the test swarm data record which values there are for each feature detect, we could collect that and see whether any feature detects were true or false across all supported browsers. That would mean we could drop the feature detect (or that we had a bug, as unlikely as that might be).

comment:7 Changed 7 years ago by mikesherov

Milestone: 1.81.next

comment:8 Changed 7 years ago by dmethvin

Type: enhancementfeature

Bulk change from enhancement to feature.

comment:9 Changed 7 years ago by mikesherov

Resolution: wontfix
Status: assignedclosed

So I'm going to close this ticket in favor of doing those peacemeal once we split into jQuery 1.9 and 2.0 code paths. Sorry to disappoint you, Paul :-/

Note: See TracTickets for help on using tickets.