Bug Tracker

Opened 5 years ago

Closed 4 years ago

#11101 closed bug (fixed)

Deprecate "exclusive" events option from trigger method

Reported by: jzaefferer Owned by: dmethvin
Priority: low Milestone: 1.8
Component: event Version: 1.7.1
Keywords: Cc: dmethvin
Blocked by: Blocking:

Description

Apparently trigger allows you to specify to trigger only non-namespaced events, via .trigger("click!"). Here's the implementation: https://github.com/jquery/jquery/blob/4534db196bf9475c79f74d6b62ebc866c27d06d9/src/event.js#L250-254 (line 250-254)

I don't see any mention of that in the documentation: http://api.jquery.com/trigger/

So either it should either be removed or documented.

Change History (5)

comment:1 Changed 5 years ago by addyosmani

  • Cc DaveMethvin added
  • Component changed from unfiled to effects
  • Keywords needsreview added
  • Priority changed from undecided to low

Adding needsreview. I personally think this should be documented, however if there's a good reason it hasn't been to date, it would be interesting to find out what it is :)

comment:2 Changed 5 years ago by dmethvin

  • Cc dmethvin added; DaveMethvin removed
  • Component changed from effects to event
  • Keywords needsreview removed
  • Owner set to dmethvin
  • Status changed from new to assigned

We use exclusive events internally, in data events. However we've talked about deprecating those and when we remove them we can also remove exclusive events. That would be my preference.

These have never been in the formal documentation but have been mentioned in a few places:

http://www.learningjquery.com/2007/09/namespace-your-events http://longgoldenears.blogspot.com/2010/02/jquery-namespaced-events-exclusive.html

comment:3 Changed 5 years ago by dmethvin

  • Milestone changed from None to 1.8

comment:4 Changed 5 years ago by dmethvin

  • Summary changed from Document or remove exclusive events option from trigger method to Deprecate "exclusive" events option from trigger method

comment:5 Changed 4 years ago by dmethvin

  • Resolution set to fixed
  • Status changed from assigned to closed

I will mark this as done since there are no docs changes. This ticket will serve as notice. Removal will be done as a separate ticket in 1.9.

Note: See TracTickets for help on using tickets.