Bug Tracker

Opened 8 years ago

Last modified 7 years ago

#11015 closed enhancement

Integrate with Closure Compiler — at Version 6

Reported by: dmethvin Owned by: dmethvin
Priority: high Milestone: 1.8
Component: misc Version: 1.7.1
Keywords: 1.8-discuss Cc:
Blocked by: Blocking:

Description (last modified by dmethvin)

There are several steps to this, we can break them out later:

1) Work with the Closure Compiler team to ensure that CC can parse jQuery correctly and work with the ADVANCED_OPTIMIZATIONS option.

2) Update jQuery's style guide, code, and unit tests to ensure we'll be able to use CC going forward.

3) Create a style guide for plugin writers and jQuery developers to ensure their own code is CC-worthy. Perhaps we can add some indication of CC-worthiness at the plugins site?

4) Document critical dependencies that will hamper minimization, such as using ambiguous methods like .load() or .show() (see #10997).

5) Provide a tool to users that allows them to combine jQuery with their own plugins and code for best minimization.

It's unlikely this will all get done in 1.8 but we need to figure out where it goes on the roadmap.

Change History (6)

comment:1 Changed 8 years ago by dmethvin

Component: unfiledmisc
Keywords: 1.8-discuss added
Milestone: None1.8
Owner: set to dmethvin
Priority: undecidedhigh
Status: newassigned
Type: bugenhancement

comment:2 Changed 8 years ago by timmywil

Description: modified (diff)

+1, We should keep in mind this is only for power users. We should still be concerned about regular gzip size.

comment:3 Changed 8 years ago by mikesherov


comment:4 Changed 8 years ago by Rick Waldron

Description: modified (diff)


comment:5 Changed 8 years ago by jaubourg

Description: modified (diff)

-1, Size will grow and all users EXCEPT power users will suffer.

comment:6 Changed 8 years ago by dmethvin

Description: modified (diff)

Our current plan is to put CCAO in a branch based on the final 1.8. The team consensus is that the jsdoc comments and in particular the inline type annotations make the code much less readable. Some of the CCAO code changes may be pulled into master, but in total they are 200 bytes so it's unlikely we will pull them all in.

For this to progress further after 1.8, we will require community assistance to help maintain CCAO compatibility and provide help for users wanting to build their own projects with jQuery and CCAO (see the task list above). If there is sufficient interest and participation, we will consider further integration.

Note: See TracTickets for help on using tickets.