Skip to main content

Bug Tracker

Side navigation

#10947 closed bug (invalid)

Opened December 03, 2011 08:55PM UTC

Closed December 03, 2011 10:14PM UTC

Remove redundant return value in $.Callbacks

Reported by: dcherman Owned by:
Priority: undecided Milestone: None
Component: unfiled Version: git
Keywords: Cc:
Blocked by: Blocking:

fireWith already returns this, so you can save a couple of bytes by changing fire to just return self.fireWith( this, arguments );

Attachments (0)
Change History (2)

Changed December 03, 2011 09:25PM UTC by dcherman comment:1

Ugh never mind, close this as invalid please.

Should have tested this locally first, it breaks the Deferred chainability tests.

Changed December 03, 2011 10:14PM UTC by dmethvin comment:2

resolution: → invalid
status: newclosed

And that's why we test. :)