Bug Tracker

Opened 8 years ago

Closed 8 years ago

#10947 closed bug (invalid)

Remove redundant return value in $.Callbacks

Reported by: dcherman Owned by:
Priority: undecided Milestone: None
Component: unfiled Version: git
Keywords: Cc:
Blocked by: Blocking:

Description

https://github.com/jquery/jquery/blob/master/src/callbacks.js#L213-215

fireWith already returns this, so you can save a couple of bytes by changing fire to just return self.fireWith( this, arguments );

Change History (2)

comment:1 Changed 8 years ago by dcherman

Ugh never mind, close this as invalid please.

Should have tested this locally first, it breaks the Deferred chainability tests.

comment:2 Changed 8 years ago by dmethvin

Resolution: invalid
Status: newclosed

And that's why we test. :)

Note: See TracTickets for help on using tickets.