Bug Tracker

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#10849 closed bug (invalid)

jQuery.support.hrefNormalized means the opposite of what its name implies

Reported by: ryan@… Owned by: ryan@…
Priority: undecided Milestone: None
Component: unfiled Version: 1.7.1rc1
Keywords: Cc:
Blocked by: Blocking:

Description

According to the docs (and verified by taking a quick look at the source), jQuery.support.hrefNormalized will be true if hrefs are *not* normalized, and false if they are.

This is the opposite of what the name implies, which is confusing.

See http://api.jquery.com/jQuery.support/ and https://github.com/jquery/jquery/blob/master/src/support.js#L56

Change History (3)

comment:1 Changed 10 years ago by dmethvin

Owner: set to ryan@…
Status: newpending

In general, the feature detects are set so they are false for browser that are a pain in the butt. So by that measure it's got the right value, perhaps it has the wrong name.

We have contemplated taking the entire jQuery.support object to deprecation land because we do not want to support specific properties as an external interface if we do not need them. Were you just observing that it seemed backwards, or are you planning to use it?

comment:2 Changed 10 years ago by Ryan Grove <ryan@…>

I don't have plans to use it; just happened to notice the confusing name. I agree that changing the name would be a reasonable solution, although "hrefNotNormalized" is a little unwieldy. Maybe someone has a better suggestion.

comment:3 Changed 10 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.