Skip to main content

Bug Tracker

Side navigation

#10794 closed bug (fixed)

Opened November 15, 2011 03:14PM UTC

Closed November 15, 2011 03:24PM UTC

Last modified March 08, 2012 03:22PM UTC

.triggerHandler should not .preventDefault()

Reported by: dmethvin Owned by: dmethvin
Priority: high Milestone: 1.7.1
Component: event Version: 1.7
Keywords: Cc:
Blocked by: Blocking:

Currently, .triggerHandler() calls event.preventDefault() to avoid the default action running. However, this prevents the caller from using the default action indication that might be returned by one of the handlers. Since we have an onlyHandlers variable we can use that instead and not mess with the event.

Attachments (0)
Change History (4)

Changed November 15, 2011 03:14PM UTC by dmethvin comment:1

component: unfiledevent
milestone: None1.7.1
owner: → dmethvin
priority: undecidedhigh
status: newassigned

Changed November 15, 2011 03:16PM UTC by dmethvin comment:2

blocking: → 10699

Changed November 15, 2011 03:24PM UTC by Dave Methvin comment:3

resolution: → fixed
status: assignedclosed

Fix #10794. .triggerHandler() should not .preventDefault().

This also provides a resolution for #10699.

Changeset: 6736dd7168ccd1e6d72aca2e3c89d685c5d9c63a

Changed February 16, 2012 11:43PM UTC by dmethvin comment:4

blocking: 10699

(In #10699) @maranomynet, I closed this ticket because I thought we'd addressed the common use cases. If I am to interpret your snarky posts and tweets, we haven't addressed a use case that is important to you.

Can you describe your situation a bit more? Is there a reason why the handlers themselves cannot stop propagation?