Bug Tracker

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10693 closed enhancement (fixed)

generalize the "test something in an iframe" code in unit tests

Reported by: mikesherov Owned by: mikesherov
Priority: low Milestone: 1.7.2
Component: build Version: 1.7
Keywords: Cc:
Blocked by: Blocking:


there are 3 different pieces of code in 3 different unit test modules:

support.js: supportIFrameTest
selector.js: testIframe
offset.js: testoffset

testIframe and testOffset are almost exact duplicates. supportIFrameTest is close enough. I was about to start writing another one for a ticket I'm trying to fix in event.js, but perhaps it's time to DRY this code and move it into test/data/testinit.js ?

I'd be glad to take a stab at it. 1.8?

Change History (4)

comment:1 Changed 5 years ago by dmethvin

  • Component changed from unfiled to build
  • Milestone changed from None to 1.8
  • Priority changed from undecided to low
  • Status changed from new to open

Sounds like a good idea!

comment:2 Changed 5 years ago by mikesherov

  • Owner set to mikesherov
  • Status changed from open to assigned

comment:3 Changed 5 years ago by mikesherov

  • Milestone changed from 1.8 to 1.7.2

comment:4 Changed 5 years ago by mikesherov

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.