Bug Tracker

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#10644 closed bug (worksforme)

jQuery performce issue in support function

Reported by: nkhanna@… Owned by: timmywil
Priority: high Milestone: 1.next
Component: support Version: 1.6.4
Keywords: Cc:
Blocked by: Blocking:

Description

We are using jQuery 1.6.4 in few project at eBay and found that following line of code in jQuery.support takes around 100 ms in Firefox and IE:

support.boxModel = div.offsetWidth === 2;

if ( "zoom" in div.style ) { ...... }

Any suggestions how can this be improved or can it be fixed.

It is HTML5 page with <!DOCTYPE html>

Thanks Neeraj

Change History (11)

comment:1 Changed 7 years ago by dmethvin

Owner: set to nkhanna@…
Status: new → pending

Interesting. How are you measuring the time it takes?

comment:2 Changed 7 years ago by Neeraj Khanna <nkhanna@…>

We are using "dynatrace" to check the execution time for each function and this turned out to be one of the biggest issue on our page, total execution is about 280 ms and 100 ms accounts for just this one line.

comment:3 Changed 7 years ago by anonymous

Run dyntrace against ​http://r1test.ebay.com/sch/i.html?_nkw=nike for Firefox

comment:4 Changed 7 years ago by dmethvin

Component: unfiled → support
Milestone: None → 1.7.1
Priority: undecided → high
Status: pending → open

We'll look into this for 1.7.1, we were planning to do some work there anyway. Thanks!

comment:5 Changed 7 years ago by Neeraj Khanna <nkhanna@…>

Thanks,

What is timeline for 1.7? In the meanwhile can you suggest a patch to fix this?

comment:6 Changed 7 years ago by timmywil

For now, you could change the line to: 

if ( typeof div.style.zoom !== "undefined ) {

but we'll be doing extensive performance testing of support.js in 1.7.1

comment:7 Changed 7 years ago by timmywil

Owner: changed from nkhanna@… to timmywil
Status: open → assigned

comment:8 Changed 7 years ago by Neeraj Khanna <nkhanna@…>

I apologize if I was not clear in my ticket, problem is in this line:

support.boxModel = div.offsetWidth === 2;

not in zoom.

I found the following thread in stackoverflow discussing the same thing, but the reason mentioned doesn't apply to our case as we have doctype for HTML5 on the page.

​http://stackoverflow.com/questions/6225664/jquery-div-offsetwidth-poor-perfomance

comment:9 Changed 7 years ago by timmywil

I'm not able to reproduce. ​http://jsfiddle.net/timmywil/nLxmG/6/show

comment:10 Changed 7 years ago by Rick Waldron

Milestone: 1.7.1 → 1.next

comment:11 Changed 7 years ago by timmywil

Resolution: → worksforme
Status: assigned → closed

Closing until this issue can be reproduced. Support has already undergone some changes.

Note: See TracTickets for help on using tickets.