Skip to main content

Bug Tracker

Side navigation

#10498 closed bug (wontfix)

Opened October 14, 2011 03:52PM UTC

Closed May 28, 2012 04:59PM UTC

matchesSelector is missing oooOOOOOooOOoOOO!

Reported by: jonathantneal Owned by: timmywil
Priority: high Milestone: None
Component: selector Version: 1.7b2
Keywords: Cc: miketaylr
Blocked by: Blocking:

Line 4987 of reads:

matches = html.matchesSelector || html.mozMatchesSelector || html.webkitMatchesSelector || html.msMatchesSelector;

Whoa whoa whoa, buddy, hang on a minute, cause nobody is singing' but I swear it looks like somebody prematurely ended an Opera. Ahem, OPERA, ahem!


Oh yea! html.oMatchesSelector? Yea! html.oMatchesSelector!

Think of how much you could improve the experience of dozens upon dozens of web users by patching this.

Attachments (0)
Change History (8)

Changed October 14, 2011 04:01PM UTC by dmethvin comment:1

cc: → miketaylr
component: unfiledselector
priority: undecidedhigh
status: newopen

Well considering they just added it in 11.5, we aren't too far behind. Seems like an easy fix though.

you could improve the experience of dozens upon dozens of web users by patching this

Will you be here all week?

Changed October 14, 2011 04:04PM UTC by miketaylr comment:2

Heh, nice catch. I can send along a pull request later this afternoon.

Changed October 14, 2011 04:58PM UTC by jdalton comment:3

Keep in mind matchesSelector is still pretty buggy:

NWMatcher pulled its matchesSelector support because it was slower (with all the checks) than its manual match method.

Changed October 14, 2011 05:44PM UTC by miketaylr comment:4

Oof, looks buggy indeed in Webkit--passing in Opera. ;)

Changed October 14, 2011 06:26PM UTC by miketaylr comment:5

Changed November 03, 2011 02:42PM UTC by timmywil comment:6

I think we should consider removing all matchesSelector usage as well.

Changed November 08, 2011 02:10PM UTC by miketaylr comment:7

owner: → timmywil
status: openassigned

Changed May 28, 2012 04:59PM UTC by timmywil comment:8

resolution: → wontfix
status: assignedclosed

matchesSelector has been removed.