Opened 11 years ago
Closed 11 years ago
#10498 closed bug (wontfix)
matchesSelector is missing oooOOOOOooOOoOOO!
Reported by: | jonathantneal | Owned by: | Timmy Willison |
---|---|---|---|
Priority: | high | Milestone: | None |
Component: | selector | Version: | 1.7b2 |
Keywords: | Cc: | miketaylr | |
Blocked by: | Blocking: |
Description
Line 4987 of http://ajax.googleapis.com/ajax/libs/jquery/1/jquery.js reads:
matches = html.matchesSelector || html.mozMatchesSelector || html.webkitMatchesSelector || html.msMatchesSelector;
Whoa whoa whoa, buddy, hang on a minute, cause nobody is singing' but I swear it looks like somebody prematurely ended an Opera. Ahem, OPERA, ahem!
Oh yea! html.oMatchesSelector? Yea! html.oMatchesSelector!
Think of how much you could improve the experience of dozens upon dozens of web users by patching this.
Change History (8)
comment:1 Changed 11 years ago by
Cc: | miketaylr added |
---|---|
Component: | unfiled → selector |
Priority: | undecided → high |
Status: | new → open |
comment:2 Changed 11 years ago by
Heh, nice catch. I can send along a pull request later this afternoon.
comment:3 Changed 11 years ago by
Keep in mind matchesSelector is still pretty buggy: http://dl.dropbox.com/u/513327/chrome_matchesselector_bug.html
NWMatcher pulled its matchesSelector support because it was slower (with all the checks) than its manual match method.
https://github.com/dperini/nwmatcher/issues/40 https://github.com/dperini/nwmatcher/commit/10a48ac54c3673c125c540447bb74c75cd1a9ed4
comment:6 Changed 11 years ago by
I think we should consider removing all matchesSelector usage as well.
comment:7 Changed 11 years ago by
Owner: | set to Timmy Willison |
---|---|
Status: | open → assigned |
comment:8 Changed 11 years ago by
Resolution: | → wontfix |
---|---|
Status: | assigned → closed |
matchesSelector has been removed.
Well considering they just added it in 11.5, we aren't too far behind. Seems like an easy fix though.
Will you be here all week?