use @hidden attribute to toggle visibility

[paul.irish]

(in supporting browsers)

That way we dont need to capture current display value, cache it, and restore it.

​http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-hidden-attribute

Implemented in FF, Chrome, Saf, and Opera: ​http://en.wikipedia.org/wiki/Comparison_of_layout_engines_(HTML5)#Global

[rwaldron]

This will be nice if it can stop the defaultDisplay() path

[mikesherov]

Holy shit we need this. defaultDisplay() is a disaster.

[timmywil]

We've explored this before and it didn't seem to give us much. Unfortunately, we'll always need defaultDisplay and we'll always have to check, if for no other reason than user stylesheets can set display to none.

[rwaldron]

Replying to mikesherov:

Holy shit we need this. defaultDisplay() is a disaster.

Rude :P

[rwaldron]

Also, defaultDisplay() doesn't have anything to do with determining if something is hidden or not displayed. It's purpose is to restore display to the correct value for a given node; regardless of what the user land code has done.

[dmethvin]

Bulk change from enhancement to feature.

[anonymous]

I want to implement this.

What’s the expected behavior? Should IE<10 use old way and browsers that support hidden just toggle hidden attr?

[dmethvin]

I think that's part of the assignment. Also to determine whether this complicates our own internal checks to see if an element is hidden. If we end up having to create two completely different paths for hiding elements and need additional checks for hidden elements, the benefits would have to be really good.

Also just to clarify, the team may vote that a feature is worth investigating and even implementing, but determine that the final result isn't worth its code or complexity cost. The vote is not a commitment to land any particular code.

[dmethvin]

-1, We'd need the old path, even in jQuery 2.0, since IE9 doesn't have @hidden. Can't imagine any perf benefit either.

[mikesherov]

-1, Seems like unnecessary complexity until all browsers without this feature die. It's unfortunate.

[gibson042]

-1 for the foreseeable future.

[gibson042]

-1

[dmethvin]

No benefit until post-IE9 so let's not tackle any time soon.