Opened 7 years ago
Closed 7 years ago
#10435 closed enhancement (wontfix)
jQuery.merge refactor
| Reported by: | MikeS | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | None |
| Component: | core | Version: | 1.7b1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
- the code for guessing that 2nd argument is an object is:
if ( typeof second.length === "number" ) {
it will work incorrectly for strings, plain objects with 'length' property etc. Why not use jQuery.isPlainObject here?
- if both arguments are plain arrays, why no use Array.concat method?
Change History (1)
comment:1 Changed 7 years ago by
| Component: | unfiled → core |
|---|---|
| Priority: | undecided → low |
| Resolution: | → wontfix |
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
The simplicity and speed of merge is much more important than allowing any type of arguments, given its vast usage internally.