Select some text. Invoke a script that does wrap and unwrap. See your selection changed or cleared.

Can be demonstrated on ​https://api.jquery.com/wrap/ select some text in the demo and press the button

Why this is a problem: I encountered a script today on a website that uses wrap to create a 'share on twitter' icon (on mousedown).

This behavior is not intended, and a hidden 'feature' that should not be there.

(function(){
    $.fn.share = function(options) {
        var option = $.extend($.fn.share.defaults,options);
        $.extend($.fn.share,{
            init : function(shareable) {
                var self = this;
                $.fn.share.defaults.shareable = shareable;
                $.fn.share.defaults.shareable.on('mouseup',function(){
                    self.popOver();
                });
                $.fn.share.defaults.shareable.on('mousedown',function(){
                    self.destroy();
                });
            },
            getContent : function() {
                var current_url = window.location.href
                var selected_text = this.getSelection('string').substring(0,option.maxLength-(current_url.length+option.author_name.length+7));
                var text = encodeURIComponent('\"'+selected_text+'\" '+'[email protected]'+option.author_name+' '+current_url)
                return '<a onclick="window.open(\''+option.shareLink+text+'\',\'_'+option.target+'\',\'location=yes,height=570,width=520,scrollbars=yes,status=yes\')"><i class="fa fa-twitter fa-lg"/></a>';
            },
            getSelection : function(share) {
                if(window.getSelection){
                    return (share=='string')?String(window.getSelection().getRangeAt(0)).replace(/\s{2,}/g, ' '):window.getSelection().getRangeAt(0);
                }
                else if(document.selection){
                    return (share=='string')?document.selection.createRange().text.replace(/\s{2,}/g, ' '):document.selection.createRange();
                }
            },
            popOver : function() {
                this.destroy();
                if(this.getSelection('string').length < option.minLength)
                    return;
                var data = this.getContent();
                var range = this.getSelection();
                var newNode = document.createElement("mark");
                range.surroundContents(newNode);
                $('mark').addClass(option.className);
                $('.'+option.className).popover({trigger:'manual', placement: option.placement, html: true 
                , content:function(){
                        return data;
                    }
                });
                $('.'+option.className).popover('show');
            },
            destroy : function(){
                $('.'+option.className).popover('hide');
                $('mark').contents().unwrap();
                $('mark').remove();
            }
        });
        $.fn.share.init(this);
    };
    
    $.fn.share.defaults = {
        shareLink : "http://twitter.com/intent/tweet?text=",
        minLength  : 2,
        maxLength  : 140,
        target     : "blank",
        className  : "share",
        placement  : "top",
    };

}());

OS system :winxp IIS7.5

after web application running several days,web application happen error.

error follow:

message: 文字列を指定してください。 line: 6 文字: 14631 code: 0 URI: /jquery-1.10.2.min.js

message: 'jQuery' は宣言されていません。 line: 6 文字: 1 code: 0 URI: */jquery-ui-1.10.3.custom.min.js

thank you

As per ​https://github.com/jquery/jquery/blame/d41e81980ea89e56c04eb14d8c27f4692b367604/src/ajax.js#L221 It seems that the dataType converters are not called when isSuccess is false

This means that it's not possible to rely on jQuery dataType automatic decoding if it's not a success response. Is there a reason why is this so ? Our "REST" implementation uses HTTP status code to convey the global success/failure of the request, and we also use a payload to describe precisely the status when possible.