Bug Tracker

#9925 closed bug (invalid)

Opened July 28, 2011 01:49AM UTC

Closed August 12, 2011 07:58AM UTC

dom object sort

Reported by: wei.shen@aispeech.com Owned by: wei.shen@aispeech.com
Priority: low Milestone: None
Component: unfiled Version: 1.6.2
Keywords: Cc:
Blocked by: Blocking:
Description

Line: 4650

return a.compareDocumentPosition(b) & 4 ? -1 : 1;

why not

return a.compareDocumentPosition(b) & 12 ? -1 : 1;

Remarks

DOCUMENT_POSITION_DISCONNECTED = 1
DOCUMENT_POSITION_PRECEDING = 2
DOCUMENT_POSITION_FOLLOWING = 4
DOCUMENT_POSITION_CONTAINS = 8
DOCUMENT_POSITION_CONTAINED_BY = 16
DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC = 32
Attachments (0)
Change History (2)

Changed July 28, 2011 10:54AM UTC by addyosmani comment:1

owner: → wei.shen@aispeech.com
priority: undecided → low
status: new → pending

Thanks for taking the time to contribute to the jQuery project! Please provide a complete reduced test case on jsFiddle to help us assess your ticket!

We'll need some more information as your ticket doesn't contain a lot to go on beyond mentioning DOM sort.

Additionally, be sure to test against the jQuery Edge version to ensure the issue still exists. To get you started, use this boilerplate: http://jsfiddle.net/FrKyN/

Open the link and click to "Fork" (in the top menu) to get started.

Changed August 12, 2011 07:58AM UTC by trac-o-bot comment:2

resolution: → invalid
status: pending → closed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!