Bug Tracker

Modify

Ticket #9476 (closed bug: invalid)

Opened 2 years ago

Last modified 21 months ago

Calling jQuery("html")[0].removeAttribute throws exception in IE <9

Reported by: rwaldron Owned by: rwaldron
Priority: low Milestone: 1.next
Component: data Version: 1.6.1
Keywords: Cc: jdalton
Blocking: Blocked by:

Change History

comment:1 Changed 2 years ago by rwaldron

  • Owner set to rwaldron
  • Priority changed from undecided to low
  • Status changed from new to assigned
  • Component changed from unfiled to support

comment:2 Changed 2 years ago by rwaldron

comment:3 Changed 2 years ago by rwaldron

  • Cc jdalton added
  • Component changed from support to data

Initially I assumed this would be straight forward, however attempts at writing a failing test ( based on Line 6-7 of the gist provided by Angus Croll [ here:  https://gist.github.com/1001726 ]) are unsuccessful.

This test case produced by jdalton was also unsuccessful in reproducing the issue.  https://dl.dropbox.com/u/513327/jq_removeAttribute.html

Verification of approach is appreciated, here is the current test I've written:

 https://github.com/rwldrn/jquery/blob/a3a301bb5d2b7dcdc1ba12f53b70cddc10607774/test/unit/data.js#L512-535

comment:4 Changed 2 years ago by timmywil

This is a common enough problem, I don't think we need a working test case for it. IE calls the function even when accessed. This often works anyway, but it's best practice to check with typeof or do "removeAttribute" in elem (I prefer the latter).

comment:5 Changed 2 years ago by anonymous

I don't think it's a common enough problem. I am pretty well versed on IE bugs and this one I am not familiar with. Without a working (failing) test case I would simply consider this dev error in diagnosing the problem.

comment:6 Changed 2 years ago by jdalton

I forgot to login. The previous comment was mine :P

However I do use an isHostType() function to help avoid these kinda of errors in IE for known problem properties and unknown properties.

 http://jsbin.com/erukiv

Last edited 2 years ago by jdalton (previous) (diff)

comment:7 Changed 21 months ago by dmethvin

  • Status changed from assigned to closed
  • Resolution set to invalid

Lacking a test case, I'm going to close this bug. Twitter is not a good way to report bugs, and his suggested fix of checking for typeof==function doesn't work in IE anyway, as I'm sure we all know.

comment:8 Changed 21 months ago by dmethvin

Oh, I see what timmywil is saying and yes, IE will sometimes call a host function even if you just access it as a property. If you think there's enough info and it can/should be fixed, feel free to reopen.

comment:9 Changed 21 months ago by timmywil

I'm just now seeing the responses. Yes, the common IE issue i was referring to was calling the function when only accessed as a property. We've run into that several times, but it is not an issue with every function.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.