Side navigation
#9401 closed enhancement (wontfix)
Opened May 22, 2011 07:22PM UTC
Closed June 06, 2011 06:42PM UTC
Better Hooks Organization
| Reported by: | rwaldron | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7 |
| Component: | core | Version: | 1.6.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Is it too late to change all these "fooHooks" into something a little more organized, like... https://gist.github.com/973761
Attachments (0)
Change History (14)
Changed May 22, 2011 07:28PM UTC by comment:1
| keywords: | → 1.7-discuss |
|---|
Changed May 22, 2011 08:09PM UTC by comment:2
+1,
Changed May 23, 2011 01:09AM UTC by comment:3
+1,
Changed May 23, 2011 04:32AM UTC by comment:4
+1, Sounds great, as long as we keep the original hook points as well (maybe we can have special events in here as well?).
Changed May 23, 2011 05:13AM UTC by comment:5
+1,
Changed May 23, 2011 05:09PM UTC by comment:6
-1, straight up yak shaving. no benefit to users. (I don't think anyone will be iterating over all hooks)
Changed May 23, 2011 05:15PM UTC by comment:7
@paul.irish the proposal isn't meant to directly benefit the users, it's primarily for improving maintenance and organization of internal code.
Changed May 23, 2011 11:57PM UTC by comment:8
| component: | unfiled → core |
|---|---|
| priority: | undecided → low |
| status: | new → open |
Changed May 24, 2011 10:35PM UTC by comment:9
-1, This seems like rearranging the sock drawer to me, is there any pro to balance the con of going back and fixing all the existing code?
Changed June 04, 2011 10:15PM UTC by comment:10
+1
Changed June 05, 2011 10:04PM UTC by comment:11
+0, It seems like all these "fooHooks" are just kind of ugly looking, but on the other hand, at least they give primacy to the thing that's being manipulated - "css" comes before "hooks" - whereas with the object of jQuery.hooks, there's just this abstract concept of "hooks" - which most people thought jQuery had long before we ever had any. (Heard the phrase "jQuery hooks into the document ready event" recently enough?) So it kind of makes it more confusing for people who need to use it, but yeah, it certainly is less than "appealing" as is...
Changed June 06, 2011 02:52PM UTC by comment:12
+1
Changed June 06, 2011 03:48PM UTC by comment:13
-1, I fail to see how this is any more organized
Changed June 06, 2011 06:42PM UTC by comment:14
| keywords: | 1.7-discuss |
|---|---|
| milestone: | 1.next → 1.7 |
| resolution: | → wontfix |
| status: | open → closed |
Nominating ticket for 1.7 discussion.