Bug Tracker

Ticket #9398 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

Proposal for Improved Deferreds

Reported by: jaubourg Owned by: jaubourg
Priority: blocker Milestone: 1.7
Component: deferred Version: 1.6.1
Keywords: 1.7-discuss Cc:
Blocking: Blocked by:

Description (last modified by dmethvin) (diff)

This proposal is a two parter:

  1. introduce progress callbacks on Deferreds (just as suggested in the Promise/A proposal). It's kind of a first step before being able to support xhr2 upload and is a much needed addition when dealing with asynchronous tasks that take a non-trivial amount of time to complete and would profit from progression notifications,
  2. while working on adding progress callbacks I realized that, while different, the logic for the progress callbacks list wasn't that far away from the one of the other two callbacks lists (the only real difference being that the progress callbacks can be called several times, while done and fail ones are only fired once). This brought me to scrap $._Deferred and go for a much more generic $.Callbacks. The advantage is that I can now implement done, fail and progress callbacks with the same base object. It also gives us an opportunity to factor our different callbacks lists throughout jQuery (meaning more robustness and a diminished code size). It can also be made public so that users can start creating callbacks lists easily.

All my experiments are located in the 1.7/callbacks branch. Still a work in progress, of course. Progress callbacks are in (though buggy atm because I screwed the memory logic of repeatable Callbacks but I'm working on it), $.when supports progress callbacks already. All instances of $._Deferred have been replaced by $.Callbacks objects.

To have an idea of how it would work, see:

Change History

comment:1 Changed 4 years ago by john

  • Keywords 1.7-discuss added

Nominating ticket for 1.7 discussion.

comment:2 Changed 4 years ago by rwaldron

  • Description modified (diff)

+1, DRY opportunity

comment:3 Changed 4 years ago by jaubourg

+1,

comment:4 Changed 4 years ago by timmywil

+1,

comment:5 Changed 4 years ago by jaubourg

  • Description modified (diff)

I added a crude named channel system to give an idea of how pub/sub could be implemented using $.Callbacks:  https://github.com/jquery/jquery/commit/96b0089c9ce5c65f9d002966256d90e778345a2a

comment:6 Changed 4 years ago by jaubourg

  • Description modified (diff)

comment:7 Changed 4 years ago by timmywil

  • Owner set to jaubourg
  • Priority changed from undecided to high
  • Status changed from new to assigned
  • Component changed from unfiled to deferred

comment:8 Changed 4 years ago by dmethvin

+1, Let me get this straight. Jaubourg is proposing to reduce code size? Damn I'm gonna vote for this just to see him try!

comment:9 Changed 4 years ago by john

  • Description modified (diff)

+0

comment:10 Changed 4 years ago by addyosmani

+0

Version 0, edited 4 years ago by addyosmani (next)

comment:11 Changed 4 years ago by ajpiano

  • Description modified (diff)

+1

comment:12 Changed 4 years ago by danheberden

  • Description modified (diff)

+1

comment:13 Changed 3 years ago by dmethvin

  • Priority changed from high to blocker
  • Description modified (diff)
  • Milestone changed from 1.next to 1.7

comment:14 Changed 3 years ago by timmywil

@jaubourg: jörn, dave, and I were wondering if all of the flags were necessary. If they are not going to be used in 1.7, we may want to wait until 1.8 to add them. Could you provide more details on their usefulness?

comment:15 Changed 3 years ago by jaubourg

once and memory are used by $.Deferred.

unique, stopOnFalse and addAfterFire are useful for event-like lists (unique ensures the same handler will only be called once, stopOnFalse ensures you can "interrupt" firing the list, addAfterFire makes it so when you add a new callback to the list while it is firing then said callback won't be fired as part of current run).

relocate I added after a discussion with Yehuda at jqcon when he told me he had a need for "Deferreds that would have some kind of callback re-ordering facility" (a reverse option would be nice to have callbacks called from the last to the first one in the same vein btw).

queue is more of an experimental flag I put hoping, at the time, that we may be able to replace existing queues with $.Callbacks-based queues.

Apart from queue, these flags are pretty generic in what they do. Just tried to cover as much ground as possible. Not sure about the flag names to be honest, as usual, any help with that is more than welcome.

I'm also not sure the complexity added with the filter parameter is really needed. Just let me know what your review brings and I'll gladly cut (this was the sense of my request for a code review).

Note: See TracTickets for help on using tickets.