Bug Tracker

Modify ↓

Ticket #8557 (closed bug: invalid)

Opened 2 years ago

Last modified 2 years ago

jQuery does not pass jslint

Reported by: etiger13 Owned by: etiger13
Priority: undecided Milestone: 1.next
Component: build Version: 1.5.1
Keywords: Cc:
Blocking: Blocked by:

Description

There are a few places where jQuery does not pass jslint. Mostly it is === vs == and !== vs !=

Change History

comment:1 Changed 2 years ago by etiger13

Cleaned up and sent in a pull request

comment:2 Changed 2 years ago by rwaldron

  • Owner set to etiger13
  • Status changed from new to pending
  • Component changed from unfiled to build

Can you link the PR?

comment:3 Changed 2 years ago by dmethvin

When you do a make on the current master it runs jslint and I get no errors. (Take a look at  https://github.com/jquery/jquery/blob/master/build/jslint-check.js to see the filtering we do.) It sounds like you're running bare jslint against the uncompressed jquery.js file?

comment:4 Changed 2 years ago by john

  • Status changed from pending to closed
  • Resolution set to invalid

Yeah, we are passing our modified JSLint. More details here:  http://docs.jquery.com/JQuery_Core_Style_Guidelines#JSLint

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.