Side navigation
#8557 closed bug (invalid)
Opened March 17, 2011 10:39PM UTC
Closed March 30, 2011 07:24PM UTC
jQuery does not pass jslint
| Reported by: | etiger13 | Owned by: | etiger13 |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.next |
| Component: | build | Version: | 1.5.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
There are a few places where jQuery does not pass jslint. Mostly it is === vs == and !== vs !=
Attachments (0)
Change History (4)
Changed March 17, 2011 10:42PM UTC by comment:1
Changed March 18, 2011 01:15AM UTC by comment:2
| component: | unfiled → build |
|---|---|
| owner: | → etiger13 |
| status: | new → pending |
Can you link the PR?
Changed March 25, 2011 05:16PM UTC by comment:3
When you do a make on the current master it runs jslint and I get no errors. (Take a look at https://github.com/jquery/jquery/blob/master/build/jslint-check.js to see the filtering we do.) It sounds like you're running bare jslint against the uncompressed jquery.js file?
Changed March 30, 2011 07:24PM UTC by comment:4
| resolution: | → invalid |
|---|---|
| status: | pending → closed |
Yeah, we are passing our modified JSLint. More details here:
Cleaned up and sent in a pull request