Ticket #8459 (closed enhancement: worksforme)
hide/show explicitly set display and leak data on the element
| Reported by: | cobexer | Owned by: | rwaldron |
|---|---|---|---|
| Priority: | low | Milestone: | 1.next |
| Component: | effects | Version: | 1.5.1 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
calling hide and show on an element explicitly sets the display property of that element and additionally fails to remove the olddisplay data property
Change History
comment:1 Changed 2 years ago by rwaldron
- Owner set to rwaldron
- Priority changed from undecided to low
- Status changed from new to assigned
- Component changed from unfiled to effects
- Type changed from bug to enhancement
comment:2 Changed 2 years ago by cobexer
rwaldron did you set it to enhancement by accident? to me this seems like a bug
comment:3 Changed 2 years ago by john
- Status changed from assigned to closed
- Resolution set to worksforme
I don't see the problem here. We want to make sure that the display is being explicitly set and it's not being affected by something in a stylesheet somewhere (and checking for that premise would make the code a lot slower). Additionally, we want to maintain olddisplay so that we don't have to re-query for it again later. I think we're OK here. Please feel free to provide another test case that you think demonstrates otherwise.
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
http://jsfiddle.net/rwaldron/8MdFy/2/