Skip to main content

Bug Tracker

Side navigation

#8044 closed bug (fixed)

Opened January 25, 2011 01:56AM UTC

Closed January 25, 2011 10:41AM UTC

Last modified March 13, 2012 02:34PM UTC

Unused variable "rnonword"?

Reported by: iszak.bryan@gmail.com Owned by: rwaldron
Priority: low Milestone: 1.5
Component: core Version: 1.5rc1
Keywords: Cc:
Blocked by: Blocking:
Description

Upon looking into jQuery 1.5 RC1 source I noticed a variable called "rnonword" which doesn't appear to be used throughout jQuery, I have also checked the trunk and it doesn't appear to be used there either. Is this a mistake or is it used?

Attachments (0)
Change History (4)

Changed January 25, 2011 02:14AM UTC by addyosmani comment:1

priority: undecidedlow
status: newopen

I notice that rnonword was used to check for non-word characters on line 180 of the source in jQuery 1.4.4 but you're correct in saying it's nowhere else to be found after its defined in 1.5. It's quite trivial to remove and should be safe to get rid of before we finalize the 1.5 release. I'll keep this open as a reminder.

Changed January 25, 2011 02:55AM UTC by rwaldron comment:2

owner: → rwaldron
status: openassigned

https://github.com/jquery/jquery/pull/207

Interesting side note: I did that in cloud9ide on a cr-48

Changed January 25, 2011 03:12AM UTC by paul.irish comment:3

I did that in cloud9ide on a cr-48

baller.

Changed January 25, 2011 10:41AM UTC by jitter comment:4

component: unfiledcore
milestone: 1.next1.5
resolution: → fixed
status: assignedclosed

Landed 8d05055.

The regex in question was a left over from a - post-1.5b1 - removed selector speed up branch.