Cleanup effects.js to improve performances and reduce filesize

Reported by:	lrbabe	Owned by:
Priority:	low	Milestone:	1.6
Component:	effects	Version:	1.4.4
Keywords:		Cc:
Blocked by:		Blocking:

Description

I've opened a pull request of small changes to effect.js that:

reduce function calls, jQuery.now() calls in particular
reduce number of out-of-scope variables lookups
cache more variables to reduce file-size once minified

It yields some interesting performance improvement, as demonstrated in this example: http://jsfiddle.net/louisremi/V3Xqt/5/ (remove patched effects.js in "manage ressources" menu to see the difference)

function calls: 1177 -> 1022 = 13% better
average execution time: 26.1 -> 23.4 = 10% better

/!\\ example might be unrealistic /!\\

As a side effect, it keeps animations synchronized and thus fixes #7917 and addresses a similar problem to #6281

Attachments (0)

Change History (4)

Changed January 14, 2011 11:55PM UTC by jitter comment:1

component:	unfiled → effects
milestone:	1.next → 1.6
priority:	undecided → low
type:	bug → enhancement

Changed January 18, 2011 06:18PM UTC by snover comment:2

status:	new → open

Changed February 08, 2011 02:11PM UTC by lrbabe comment:3

Additional benefits with last commits:

reduce function calls even more
simplifies easing resolution code
add some comments and improve code readability here and there

Changed April 16, 2011 04:18PM UTC by john comment:4

resolution:	→ fixed
status:	open → closed

This particular pull request was closed - a new open was opened up (and closed) just recently.

Side navigation