Bug Tracker

Modify

Ticket #7964 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Some traversal methods perform an unnecessary uniqueness check

Reported by: scott.gonzalez Owned by: scott_gonzalez
Priority: low Milestone: 1.5
Component: traversing Version: 1.4.4
Keywords: Cc: jeresig
Blocking: Blocked by:

Description

Methods like .children(), .next() and .prev() are guaranteed to produce a unique result when called on a unique set. These methods are generated by a function which always checks for uniqueness if the original set contained more than one element. Methods that are guaranteed to produce a unique result should not go through the uniqueness check as this is fairly expensive in some browsers.

Change History

comment:1 Changed 3 years ago by addyosmani

  • Cc jeresig added
  • Owner set to scott_gonzalez
  • Status changed from new to assigned
  • Priority changed from undecided to low

comment:2 Changed 3 years ago by john

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Component changed from unfiled to traversing
  • Milestone changed from 1.next to 1.5

This pull request was landed:  https://github.com/jquery/jquery/pull/180

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.