Checkbox's state is erased after wrap() or append() action (IE 6)

[Mehdi Kabab]

When you wrap a checkbox checked, check state is erased.

Testpage :  http://gimp4you.eu.org/sandbox/js/test/wrap.html

(jQuery 1.0.4)

[aaron.heimli]

FYI, this issue is fixed in IE7, but an IE6 fix doesn't appear to be that difficult to implement.

[Mehdi Kabab]

Ok.

I had update the testpage for added prepend method test. The result is similar in IE 6 (with append method too).

[Mehdi Kabab]

Hi,

The testpage has been update for jQuery 1.1b I'm encoured always the bug in IE 6.

[joern]

Added test in [1590].

[brandon]

The test for this seems to have changed since [1590]. It looks like the third test is testing for !checked but shouldn't it be checking for checked?

[davidserduke]

test case

[davidserduke]

This is an IE6 bug in the way it handles functions like appendChild. IE6 clears the "checked" property (even from children) during these functions. This is shown by the second button in the new test case. It really isn't a wrap issue at all except that wrap calls appendChild eventually.

The only real fix I see at this point is to save the state of the elem.checked and all its children and after the appendChild set them correctly if necessary. That is what the patch does and it fixes the test case. Unfortunately IE6 is likely to see a speed hit since it is necessary to recurse down any tree moved saving the checked values. I'm not sure it's worth it.

[davidserduke]

patch

[davidserduke]

Closed bugs #1866 and #1962 as duplicates but noting it here for reference as the first one has a test case.

[brandon]

I'm very concerned about the performance hit involved with fixing this issue. The work around is to store the value of the inputs before and restoring the values after wrapping or appending.