Skip to main content

Bug Tracker

Side navigation

#7629 closed enhancement (worksforme)

Opened November 24, 2010 09:04PM UTC

Closed April 16, 2011 11:23PM UTC

Extend coverage of stored references to core methods metaticket

Reported by: rwaldron Owned by:
Priority: low Milestone:
Component: misc Version: 1.4.4
Keywords: Cc:
Blocked by: Blocking:
Description

A comment on #6809 pointed to a patch that does some optimizations by extended the idea already in practice of storing references to core methods, strings and other "constant" type information that is frequently reused.

A VERY good resource for this practice was published by the winner of the JS1k contest, here:

http://marijnhaverbeke.nl/js1k/

Additionally, this a link to the patch:

https://github.com/monsterzz/jquery/commit/7ab7f285127fe29107a47fe486e3ea40ff51aec9

Attachments (0)
Change History (3)

Changed November 24, 2010 09:21PM UTC by rwaldron comment:1

component: unfiledmisc
description: A comment on #6809 pointed to a patch that does some optimizations by extended the idea already in practice of storing references to core methods, strings and other "constant" type information that is frequently reused. \ \ A VERY good resource for this practice was published by the winner of the JS1k contest, here: \ \ http://marijnhaverbeke.nl/js1k/ \ \ \ A comment on #6809 pointed to a patch that does some optimizations by extended the idea already in practice of storing references to core methods, strings and other "constant" type information that is frequently reused. \ \ A VERY good resource for this practice was published by the winner of the JS1k contest, here: \ \ http://marijnhaverbeke.nl/js1k/ \ \ Additionally, this a link to the patch: \ \ https://github.com/monsterzz/jquery/commit/7ab7f285127fe29107a47fe486e3ea40ff51aec9 \ \ \
priority: undecidedlow

Changed November 25, 2010 12:33AM UTC by rwaldron comment:2

status: newopen

Changed April 16, 2011 11:23PM UTC by john comment:3

resolution: → worksforme
status: openclosed

"storing references to core methods, strings and other "constant" type information that is frequently reused."

Don't we do this already? We store reference to many DOM methods, we cache all RegExp and functions at the top of our code. I think we're already OK here.

I've moved the commit above into #6809.