Bug Tracker

#7161 closed bug (fixed)

Opened October 12, 2010 11:27AM UTC

Closed September 20, 2011 12:49PM UTC

Submit event on a form element not unbound properly in IE

Reported by: gethinw Owned by: dmethvin
Priority: high Milestone: 1.7
Component: event Version: 1.4.2
Keywords: Cc:
Blocked by: Blocking:
Description

Submit events are not unbound fully from form elements in Internet Explorer. Would appear to be because jQuery.event.special.submit.setup (2199 in 1.4.2 source) is only applied if the element in question isn't a form, whereas the teardown function (2222) gets applied regardless, therefore not removing the standard submit event.

Attachments (0)
Change History (10)

Changed October 13, 2010 04:21AM UTC by addyosmani comment:1

component: unfiled → event
need: Review → Test Case
owner: → gethinw
status: new → pending

Could you submit a valid test case for us to see where this is breaking?.

Changed October 13, 2010 09:01AM UTC by gethinw comment:2

status: pending → new

Changed October 13, 2010 09:01AM UTC by gethinw comment:3

OK - found an interesting twist on this while putting together a test case:

Bug is as previously described in http://fiddle.jshell.net/kytmD/2/ - if you 'Bind' then 'Unbind' then submit the form, an error will occur.

However, if the JS is run on load ('$(window).load(...)') rather than onReady ('$(...)') - http://fiddle.jshell.net/kytmD/1/ - the error doesn't occur. This would appear to be a side-effect of the fact that attaching a load event to the window creates an object in $(window).data('events'), the lack of which (at line 1919) causes the error in the other case, but as far as I can tell the handle function (1904) shouldn't be being called at all, so this is a coincidence rather than a fix.

Changed October 14, 2010 03:13AM UTC by snover comment:4

status: new → pending

This ticket has been marked as missing a test case. In an effort to reduce the number of outstanding tickets in the bug tracker, it will be closed automatically in 30 days. In order to prevent this from happening, please provide a working test case. If a test case has already been provided and our records are wrong, please respond to the ticket so that it can be fixed. Thank you!

Changed October 14, 2010 08:23AM UTC by gethinw comment:5

status: pending → new

Test case provided in comment:2

Replying to [comment:3 snover]:

This ticket has been marked as missing a test case. In an effort to reduce the number of outstanding tickets in the bug tracker, it will be closed automatically in 30 days. In order to prevent this from happening, please provide a working test case. If a test case has already been provided and our records are wrong, please respond to the ticket so that it can be fixed. Thank you!

Changed October 14, 2010 07:43PM UTC by snover comment:6

status: new → open

Changed November 12, 2010 02:40AM UTC by snover comment:7

milestone: 1.4.3

Resetting milestone to future.

Changed April 17, 2011 08:17PM UTC by john comment:8

milestone: → 1.next
priority: undecided → high

Changed September 08, 2011 05:55PM UTC by dmethvin comment:9

milestone: 1.next → 1.7
owner: gethinw → dmethvin
status: open → assigned

I think I've fixed this IE8 bug in my 1.7 branch, I'll confirm later this month when it lands.

Changed September 20, 2011 12:49PM UTC by dmethvin comment:10

resolution: → fixed
status: assigned → closed

This is fixed as a result of the event rewrite in 1.7.