Side navigation
#7086 closed bug (fixed)
Opened September 26, 2010 08:37PM UTC
Closed September 27, 2010 12:47AM UTC
Incorrect image url in testsuite.css
Reported by: | jitter | Owned by: | |
---|---|---|---|
Priority: | low | Milestone: | 1.4.3 |
Component: | effects | Version: | 1.4.2 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
While running the effects-unit-tests browsers generate a bunch of http-requests which always fail with a http statuscode of 404 while requesting a specific image (this doesn't affect the unit-test, as they still succeed).
The requests originate from some of the effects tests adding divs with class ''box'' to a div with id ''fx-tests'' in ''test/index.html'' (see ''makeTest'' function defined in ''test/unit/effect.js'' around line 604).
In ''test/data/testsuite.css'' there is a style defined for ''div#fx-tests div.box'' but the url for the background image is invalid. Changing ''testsuite.css'' from
Line 13: background: red url(data/cow.jpg) no-repeat;
to
Line 13: background: red url(cow.jpg) no-repeat;
fixes the invalid url and failing http-requests as now the image is found. Or if the background-image isn't really needed the url could be removed altogether and thus saving a few requests
Attachments (0)
Change History (1)
Changed September 27, 2010 12:47AM UTC by comment:1
resolution: | → fixed |
---|---|
status: | new → closed |
Yeah - that's legacy code, I just removed it. Thanks for the catch!
http://github.com/jquery/jquery/commit/42aa714fb79199ad0a45d5f76f43729b399b058a