Bug Tracker

Modify ↓

Ticket #7067 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Incorrect effects-unit-test could conceal failures

Reported by: bugbegone Owned by:
Priority: undecided Milestone: 1.4.3
Component: effects Version: 1.4.2
Keywords: fx unit test Cc:
Blocking: Blocked by:

Description

In test/unit/effect.js on Line 519 the superfluous 

+ "px"

in 

notEqual(jQuery.css(this, "height") + "px", old_h, ....

should be removed.

css(...) returns the value with units intact anyway. Thus if jQuery.css(this, "height") and old_h should happen to have the same value the notEqual-check can't catch this because the appended px string causes the values to always be different.

Change History

comment:1 Changed 3 years ago by john

  • Priority set to undecided
  • Status changed from new to closed
  • Resolution set to fixed

Ha, missed this bug report but I actually just fixed this here:  http://github.com/jquery/jquery/commit/2f603359fecca5b4873c45775b293702a2c651e3

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.