Skip to main content

Bug Tracker

Side navigation

#7067 closed bug (fixed)

Opened September 22, 2010 10:46PM UTC

Closed September 23, 2010 04:11AM UTC

Incorrect effects-unit-test could conceal failures

Reported by: bugbegone Owned by:
Priority: undecided Milestone: 1.4.3
Component: effects Version: 1.4.2
Keywords: fx unit test Cc:
Blocked by: Blocking:
Description

In test/unit/effect.js on Line 519 the superfluous

#!js
+ "px"

in

#!js
notEqual(jQuery.css(this, "height") + "px", old_h, ....

should be removed.

''css(...)'' returns the value with units intact anyway. Thus if ''jQuery.css(this, "height")'' and ''old_h'' should happen to have the same value the ''notEqual''-check can't catch this because the appended ''px'' string causes the values to always be different.

Attachments (0)
Change History (1)

Changed September 23, 2010 04:11AM UTC by john comment:1

priority: → undecided
resolution: → fixed
status: newclosed

Ha, missed this bug report but I actually just fixed this here: http://github.com/jquery/jquery/commit/2f603359fecca5b4873c45775b293702a2c651e3