Bug Tracker

Modify ↓

Ticket #7034 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

effect.js uses variables defined in closure of css.js

Reported by: arrix Owned by:
Priority: Milestone: 1.4.3
Component: core Version: 1.4.2
Keywords: Cc:
Blocking: Blocked by:

Description

I got an error calling .slideDown() with the latest build: Uncaught ReferenceError: rdashAlpha is not defined

 commit bca576 added a closure for each module. rdashAlpha, fcamelCase and perhaps others are defined in the closure of css.js so effect.js can't access them.

Here two modules are sharing common variables. We can move the shared variables to an outer closure accessible by both modules. We can also invent a way for modules to import/export variables which may seem too heavy for jQuery.

Change History

comment:1 Changed 3 years ago by arrix

  • Status changed from new to closed
  • Resolution set to fixed

fixed in  http://github.com/jquery/jquery/commit/fc5b69fc706a6025e5084d4b86adb3b97840c84f

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.