Skip to main content

Bug Tracker

Side navigation

#7011 closed bug (fixed)

Opened September 08, 2010 05:43AM UTC

Closed September 08, 2010 05:57PM UTC

noConflict is broken by Commit #8effe3a7dee91c833cc1774646da9d743600c64c

Reported by: rwaldron Owned by:
Priority: Milestone: 1.4.3
Component: unfiled Version: 1.4.2
Keywords: Cc:
Blocked by: Blocking:
Description

Check out:

http://github.com/jquery/jquery/commit/8effe3a7dee91c833cc1774646da9d743600c64c#diff-2

This commit breaks jQuery.noConflict(true) - jQuery/_jQuery is actually undefined when it is called.

Removing the closure fixes the problem

Also - the unit tests are not passing because of this.

Attachments (0)
Change History (4)

Changed September 08, 2010 05:45AM UTC by rwaldron comment:1

Changed September 08, 2010 05:47AM UTC by rwaldron comment:2

Additionally, here is the test case that shows the breakage:

http://jsbin.com/ujije4/9

Changed September 08, 2010 05:21PM UTC by cowboy comment:3

The problem is that because the var jQuery declaration in core.js happens inside a core-specific closure, when any non-core jQuery function tries to resolve jQuery it must go all the way up the scope chain to window to get it, which explodes all over the place when noConflict(true) is used.

This is a pretty major issue.

Changed September 08, 2010 05:57PM UTC by john comment:4

resolution: → fixed
status: newclosed