Array incorrectly dealt as object breaking functionality of clone function when using custom Array prototype

Reported by:	fabiangebert	Owned by:	rwaldron
Priority:	low	Milestone:	1.4.3
Component:	event	Version:	1.4.2
Keywords:	clone cloneCopyEvent,prototype,array,handling	Cc:
Blocked by:		Blocking:

In line 4344 of the released 1.4.2 instead of

for ( var handler in events[ type ] ) {

it must be

for ( var handler=0;handler<events[type].length;handler++) {

since events[type] is an array.

In case you've extended the Array prototype with functions or objects, the wrong code will break functionality when using ,clone()-method.

Attachments (0)

Change History (2)

keywords:	clone,cloneCopyEvent,prototype,array,handling → needsreview, clone,cloneCopyEvent,prototype,array,handling
owner:	→ rwaldron
priority:	→ low
status:	new → assigned

jQuery is not responsible for changes to native objects - but I'm going to open this for review.

keywords:	needsreview, clone,cloneCopyEvent,prototype,array,handling → clone cloneCopyEvent,prototype,array,handling
resolution:	→ fixed
status:	assigned → closed

This was fixed in 1.4.3

Side navigation